Ashhar Ahmad Khan created FINERACT-2716:
-------------------------------------------

             Summary: SMS campaign preview JSON parsing failure is silently 
swallowed instead of logged
                 Key: FINERACT-2716
                 URL: https://issues.apache.org/jira/browse/FINERACT-2716
             Project: Apache Fineract
          Issue Type: Bug
            Reporter: Ashhar Ahmad Khan


In {{{}SmsCampaignWritePlatformServiceJpaImpl{}}}, the 
{{{}previewMessage{}}}-equivalent method catches {{IOException}} from JSON 
parsing and does nothing with it — no log, no rethrow. The exception disappears 
silently.

This is the one remaining {{// TODO throw something here}} in this class; all 
other {{catch (IOException ...)}} blocks in the same class already log and 
continue. This follows up on FINERACT-2707, which fixed the equivalent issue in 
{{{}EmailCampaignWritePlatformCommandHandlerImpl{}}}.

Fix: replace the TODO comment with a {{log.error(...)}} call, matching the 
existing convention elsewhere in the same class. No functional change otherwise.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to