Samer-Melhem-FOO opened a new pull request, #6195: URL: https://github.com/apache/fineract/pull/6195
## Description The Journal Entries API only returns `submittedOnDate` (date-only), so any UI reading it always shows a time of `00:00:00`, even though the journal entry's actual creation timestamp is stored in `acc_gl_journal_entry.created_on_utc`. This adds a new optional `submittedOnDateTime` field to `JournalEntryData` (Fineract-style `[year, month, day, hour, minute, second]` array), sourced from `created_on_utc` in `JournalEntryReadPlatformServiceImpl`. `submittedOnDate` is left unchanged for backward compatibility. JIRA: https://issues.apache.org/jira/browse/FINERACT-2719 ## Checklist - [x] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [ ] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [x] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes - [x] This PR must not be a "code dump". Large changes can be made in a branch, with assistance. - [ ] If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately. Note: no existing unit/integration test covers `JournalEntryReadPlatformServiceImpl`'s row-mapping logic (it's a plain JDBC `RowMapper`, not easily unit-testable in isolation), so none were added — happy to add integration-test coverage if a reviewer points to the right harness for it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
