Samer-Melhem-FOO opened a new pull request, #6196:
URL: https://github.com/apache/fineract/pull/6196
## Description
Two related defects in loan collateral handling (`LoanCollateralAssembler` /
`LoanAssemblerImpl`):
1. **Repeated quantity deduction.**
`LoanCollateralAssembler.fromParsedJson(...)` deducted client collateral
quantity on every call, including from read-only paths (loan application
validation, schedule preview), not just actual loan submission/update. Since
the same parsing method is reused across both, a client's available collateral
quantity could be decremented more than once for the same loan, and submitting
a loan with linked collateral could fail with an "invalid amount of collateral
quantity" error even with sufficient collateral available.
2. **Inverted change detection on loan modification.** In
`LoanAssemblerImpl`, the check that decides whether collateral changed on a
Modify Loan Application request was inverted:
```java
possiblyModifedLoanCollateralItems.equals(loan.getLoanCollateralManagements())
```
This recorded a "collateral changed" entry (and triggered
`loan.updateLoanCollateral(...)`) only when the new and existing collateral
sets were **equal** — i.e. when nothing changed — and skipped it when they
genuinely differed. Real collateral changes on loan modification were silently
dropped.
**Fix:** `LoanCollateralAssembler.fromParsedJson` now takes an explicit
`adjustClientCollateralQuantity` flag, defaulting to `false` for
read-only/validation callers (existing single-arg overload preserved) and
`true` only for actual loan submission/update. The modify-loan condition is
flipped to `!equals(...)` so genuine changes are detected and persisted.
JIRA: https://issues.apache.org/jira/browse/FINERACT-2721
## Checklist
- [x] Write the commit message as per [our
guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests)
- [x] Acknowledge that we will not review PRs that are not passing the build
_("green")_ - it is your responsibility to get a proposed PR to pass the build,
not primarily the project's maintainers.
- [ ] Create/update [unit or integration
tests](https://fineract.apache.org/docs/current/#_testing) for verifying the
changes made.
- [x] Follow our [coding
conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions).
- [ ] Add required Swagger annotation and update API documentation at
fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with
details of any API changes
- [x] This PR must not be a "code dump". Large changes can be made in a
branch, with assistance.
- [ ] If merging this PR resolves a JIRA issue, I will mark that issue as
resolved and set "Fix Version/s" appropriately.
Note: no existing unit/integration test covers
`LoanCollateralAssembler`/`LoanAssemblerImpl`'s collateral-handling logic, so
none were added — happy to add coverage if a reviewer points to the right
harness (loan submission with collateral is normally exercised via integration
tests).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
