adamsaghy commented on code in PR #6169:
URL: https://github.com/apache/fineract/pull/6169#discussion_r3666267320
##########
fineract-loan-origination/src/main/java/org/apache/fineract/portfolio/loanorigination/service/AbstractLoanOriginatorLinkingServiceImpl.java:
##########
@@ -85,9 +86,23 @@ public void processOriginatorsForLoanApplication(final Long
loanId, final JsonAr
}
}
+ /**
+ * Default no-op for modules that do not reconcile originators on
disbursement. Loan-specific linking overrides
+ * this.
+ */
+ @Override
+ public void processOriginatorsForLoanDisbursement(final Long loanId, final
JsonArray originatorsArray) {
Review Comment:
why not reusing existing one? WE can rename
`processOriginatorsForLoanApplication` to something more generic and just
reused logic AS-IS, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
