mariiaKraievska commented on code in PR #6143:
URL: https://github.com/apache/fineract/pull/6143#discussion_r3690624751


##########
fineract-working-capital-loan/src/main/java/org/apache/fineract/portfolio/workingcapitalloan/service/WorkingCapitalLoanChargeOffWriteServiceImpl.java:
##########
@@ -0,0 +1,188 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.fineract.portfolio.workingcapitalloan.service;
+
+import java.math.BigDecimal;
+import java.time.LocalDate;
+import java.util.LinkedHashMap;
+import java.util.Map;
+import lombok.RequiredArgsConstructor;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.fineract.infrastructure.codes.domain.CodeValue;
+import org.apache.fineract.infrastructure.codes.domain.CodeValueRepository;
+import org.apache.fineract.infrastructure.core.api.JsonCommand;
+import org.apache.fineract.infrastructure.core.data.CommandProcessingResult;
+import 
org.apache.fineract.infrastructure.core.data.CommandProcessingResultBuilder;
+import org.apache.fineract.infrastructure.core.domain.ExternalId;
+import 
org.apache.fineract.infrastructure.core.exception.GeneralPlatformDomainRuleException;
+import org.apache.fineract.infrastructure.core.service.DateUtils;
+import org.apache.fineract.infrastructure.core.service.ExternalIdFactory;
+import 
org.apache.fineract.infrastructure.security.service.PlatformSecurityContext;
+import org.apache.fineract.portfolio.loanaccount.domain.LoanTransactionType;
+import 
org.apache.fineract.portfolio.workingcapitalloan.WorkingCapitalLoanConstants;
+import 
org.apache.fineract.portfolio.workingcapitalloan.accounting.WorkingCapitalLoanAccountingProcessor;
+import 
org.apache.fineract.portfolio.workingcapitalloan.domain.WorkingCapitalLoan;
+import 
org.apache.fineract.portfolio.workingcapitalloan.domain.WorkingCapitalLoanBalance;
+import 
org.apache.fineract.portfolio.workingcapitalloan.domain.WorkingCapitalLoanNote;
+import 
org.apache.fineract.portfolio.workingcapitalloan.domain.WorkingCapitalLoanTransaction;
+import 
org.apache.fineract.portfolio.workingcapitalloan.domain.WorkingCapitalLoanTransactionAllocation;
+import 
org.apache.fineract.portfolio.workingcapitalloan.exception.WorkingCapitalLoanNotFoundException;
+import 
org.apache.fineract.portfolio.workingcapitalloan.repository.WorkingCapitalLoanBalanceRepository;
+import 
org.apache.fineract.portfolio.workingcapitalloan.repository.WorkingCapitalLoanNoteRepository;
+import 
org.apache.fineract.portfolio.workingcapitalloan.repository.WorkingCapitalLoanRepository;
+import 
org.apache.fineract.portfolio.workingcapitalloan.repository.WorkingCapitalLoanTransactionAllocationRepository;
+import 
org.apache.fineract.portfolio.workingcapitalloan.repository.WorkingCapitalLoanTransactionRepository;
+import 
org.apache.fineract.portfolio.workingcapitalloan.serialization.WorkingCapitalLoanDataValidator;
+import org.apache.fineract.useradministration.domain.AppUser;
+import org.springframework.stereotype.Service;
+import org.springframework.transaction.annotation.Transactional;
+
+@Slf4j
+@Service
+@RequiredArgsConstructor
+public class WorkingCapitalLoanChargeOffWriteServiceImpl implements 
WorkingCapitalLoanChargeOffWriteService {
+
+    private final PlatformSecurityContext context;
+    private final WorkingCapitalLoanRepository loanRepository;
+    private final WorkingCapitalLoanDataValidator validator;
+    private final WorkingCapitalLoanTransactionRepository 
transactionRepository;
+    private final WorkingCapitalLoanTransactionAllocationRepository 
allocationRepository;
+    private final WorkingCapitalLoanBalanceRepository balanceRepository;
+    private final WorkingCapitalLoanNoteRepository noteRepository;
+    private final CodeValueRepository codeValueRepository;
+    private final ExternalIdFactory externalIdFactory;
+    private final WorkingCapitalLoanAccountingProcessor accountingProcessor;
+
+    @Transactional
+    @Override
+    public CommandProcessingResult chargeOff(final Long loanId, final 
JsonCommand command) {
+        final WorkingCapitalLoan loan = this.loanRepository.findById(loanId)
+                .orElseThrow(() -> new 
WorkingCapitalLoanNotFoundException(loanId));
+        this.validator.validateChargeOff(command, loan);
+
+        final AppUser currentUser = this.context.authenticatedUser();
+        final LocalDate transactionDate = 
command.localDateValueOfParameterNamed(WorkingCapitalLoanConstants.transactionDateParamName);
+        final ExternalId txnExternalId = 
this.externalIdFactory.createFromCommand(command,
+                WorkingCapitalLoanConstants.externalIdParameterName);
+
+        // Resolve the optional charge-off reason.
+        final Long chargeOffReasonId = 
command.longValueOfParameterNamed(WorkingCapitalLoanConstants.chargeOffReasonIdParamName);
+        final CodeValue chargeOffReason = chargeOffReasonId != null
+                ? 
this.codeValueRepository.findByCodeNameAndId(WorkingCapitalLoanConstants.CHARGE_OFF_REASONS,
 chargeOffReasonId)
+                : null;
+
+        // The charge-off amount is the outstanding balance as of the 
charge-off date. Because the charge-off date
+        // cannot
+        // be earlier than the last transaction, the current outstanding 
equals the as-of-date balance.
+        final WorkingCapitalLoanBalance balance = 
this.balanceRepository.findByWcLoan_Id(loan.getId())
+                .orElseGet(() -> WorkingCapitalLoanBalance.createFor(loan));
+        final BigDecimal chargeOffAmount = balance.getTotalOutstanding();
+
+        // Non-monetary tag transaction: records the charged-off amount but 
does not move the running balance.
+        final WorkingCapitalLoanTransaction chargeOffTransaction = 
WorkingCapitalLoanTransaction.chargeOff(loan, chargeOffAmount,
+                transactionDate, txnExternalId);
+        this.transactionRepository.saveAndFlush(chargeOffTransaction);
+
+        // Snapshot the outstanding portions so charge-off accounting can post 
per-portion journal entries later.
+        final WorkingCapitalLoanTransactionAllocation allocation = 
WorkingCapitalLoanTransactionAllocation.forPortions(chargeOffTransaction,

Review Comment:
   Could we pass overpaymentPortion as well? On current develop forPortions 
expects 4 money args — this may not compile after rebase



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to