Aman-Mittal opened a new issue, #221:
URL: https://github.com/apache/fineract-backoffice-ui/issues/221
## What is wrong
Five action buttons on the savings account screen have their labels written
directly into the
template in English, so they stay English in every language. The same
actions on the loan account
screen go through `| translate`.
Visible on `/products/savings-accounts/view/:id` — the header row reads
**CLOSE**, **DEPOSIT**,
**WITHDRAW** in English, next to **ACTIONS** and **BACK**, which are
translated and would change
with the language. Switching the app to another language leaves the first
three in English.
## Where
`src/app/features/products/savings-account-view.component.ts`, lines 135,
168, 179, 189, 198:
```html
<ion-button ... (click)="onSavingsAction('approve')">
<ion-icon name="checkmark-circle-outline"></ion-icon>
Approve <!-- hard-coded -->
</ion-button>
```
Compare `src/app/features/loans/loan-view.component.ts:164`, which does it
the intended way:
```html
{{ 'LOANS.APPROVE' | translate }}
```
## What to change
Replace the five bare words with translation keys and add them to
`src/assets/i18n/en.json` under
the existing `SAVINGS` block. Some already exist — check before adding:
| Line | Current text | Suggested key |
|---|---|---|
| 135 | `Approve` | `SAVINGS.APPROVE` |
| 168 | `Activate` | `SAVINGS.ACTIVATE` |
| 179 | `Close` | `SAVINGS.CLOSE` |
| 189 | `Deposit` | `SAVINGS.DEPOSIT` |
| 198 | `Withdraw` | `SAVINGS.WITHDRAW` |
Each button already has an `[appTooltip]` bound to a `SAVINGS.*` key nearby,
so the naming
convention to follow is right there.
## How to check it
```bash
npm run i18n:check # fails if a key is referenced but missing from
en.json
npm run build
```
Then run the app, switch the language in the header, and confirm the buttons
change with it.
## Why it is worth doing
The application ships three locales. A button that ignores the language
setting is not a cosmetic
detail for someone using the app in Hindi or Korean — it is a control they
cannot read, on a
screen that moves money.
Good first issue: five lines plus five translation keys, with a clear worked
example to copy from
in the loan view.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
