adamsaghy commented on code in PR #6141:
URL: https://github.com/apache/fineract/pull/6141#discussion_r3702879219
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/group/service/AllGroupTypesDataMapper.java:
##########
@@ -80,7 +80,8 @@ public GroupGeneralData mapRow(final ResultSet rs,
@SuppressWarnings("unused") f
final Long id = rs.getLong("id");
final String accountNo = rs.getString("accountNumber");
final String name = rs.getString("name");
- final String externalId = rs.getString("externalId");
+ final String rawExternalId = rs.getString("externalId");
+ final String externalId = rawExternalId != null &&
!rawExternalId.isBlank() ? rawExternalId : "null";
Review Comment:
why to hardcode "null" as string?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
