adamsaghy commented on PR #6144: URL: https://github.com/apache/fineract/pull/6144#issuecomment-5165610996
> Hey @adamsaghy , thanks for the notice. > > #6136 does touch the same undo() method, but it doesn't add support for the loan to savings case. It only fixes the lookup and scoping logic for the branches that already existed. My PR is completing the last piece of the pattern from [FINERACT-2604](https://issues.apache.org/jira/browse/FINERACT-2604) and [FINERACT-2613](https://issues.apache.org/jira/browse/FINERACT-2613), so it's still needed on top of that fix. > > Right now my loan to savings branch is written in the old loop style though, so once #6136 merges it'll conflict. I'll wait for that to land, rebase, and rewrite my branch to match their single transaction pattern instead. > > Thanks again for pointing this out! It was not just different handling, but it is using different entity to be fetched by id. Please double check whether your implementation is fetching the correct entity -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
