IOhacker commented on code in PR #6219:
URL: https://github.com/apache/fineract/pull/6219#discussion_r3706144849
##########
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/savings/AccountTransferHelper.java:
##########
@@ -100,6 +113,37 @@ public Integer accountTransfer(final Integer fromClientId,
final Integer fromAcc
accountTransferJSON, "savingsId");
}
+ @Deprecated(forRemoval = true)
+ public Long accountTransferReturningResourceId(final Integer fromClientId,
final Integer fromAccountId, final Integer toClientId,
+ final Integer toAccountId, final String fromAccountType, final
String toAccountType, final String transferAmount,
+ final Map<String, Object> paymentDetails) {
+ LOG.info("--------------------------------ACCOUNT
TRANSFER--------------------------------");
Review Comment:
@AnvayKharb this can be debug or why it is info level?
##########
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/savings/AccountTransferHelper.java:
##########
@@ -100,6 +113,37 @@ public Integer accountTransfer(final Integer fromClientId,
final Integer fromAcc
accountTransferJSON, "savingsId");
}
+ @Deprecated(forRemoval = true)
+ public Long accountTransferReturningResourceId(final Integer fromClientId,
final Integer fromAccountId, final Integer toClientId,
+ final Integer toAccountId, final String fromAccountType, final
String toAccountType, final String transferAmount,
+ final Map<String, Object> paymentDetails) {
+ LOG.info("--------------------------------ACCOUNT
TRANSFER--------------------------------");
+ final String accountTransferJSON = new
AccountTransferHelper(this.requestSpec, this.responseSpec) //
+ .withTransferOnDate(ACCOUNT_TRANSFER_DATE) //
+ .build(fromAccountId.toString(), fromClientId.toString(),
toAccountId.toString(), toClientId.toString(), fromAccountType,
+ toAccountType, transferAmount, paymentDetails);
+ final Integer resourceId = Utils.performServerPost(this.requestSpec,
this.responseSpec,
+ ACCOUNT_TRANSFER_URL + "?" + Utils.TENANT_IDENTIFIER,
accountTransferJSON, "resourceId");
+ return resourceId.longValue();
+ }
+
+ @Deprecated(forRemoval = true)
+ public Object invalidAccountTransferWithPaymentDetails(final Map<String,
Object> paymentDetails) {
+ LOG.info("--------------------------------ACCOUNT
TRANSFER--------------------------------");
Review Comment:
@AnvayKharb this can be debug or why it is info level?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
