AshharAhmadKhan opened a new pull request, #6228: URL: https://github.com/apache/fineract/pull/6228
JIRA https://issues.apache.org/jira/browse/FINERACT-2738 Problem When the Idempotency-Key header is missing on a request, it is processed silently. No log, no signal, no observability. This creates a risk of unintended duplicate command processing going unnoticed. This was originally raised in FINERACT-2591, and an earlier attempt (PR #5873) implemented unconditional WARN logging. That approach was rejected in review, since it would spam logs for every client that does not use idempotency handling. Fix Added a new global configuration option, enable-idempotency-validation, disabled by default for backward compatibility. When enabled, a WARN level log is emitted if the Idempotency-Key header is missing on a request. The flag is read through the cached global configuration service (ConfigurationDomainService), following the same pattern used elsewhere in the codebase. No existing request processing behavior changes. This is observability only, and off by default. Testing Added IdempotencyStoreFilterTest covering all four branches: validation disabled, content type not allowed, header present, and header missing with validation enabled. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
