NkwaTambe opened a new pull request, #247:
URL: https://github.com/apache/fineract-backoffice-ui/pull/247
## What and why
Add a `concurrency` group to `ci.yml`, `e2e.yml` and `codeql.yml` so a new
push to a pull request cancels the run for the code it replaced. This speeds up
feedback (superseded runs no longer hold runner slots) and removes ambiguous
results where a PR briefly shows two commits' worth of statuses.
The group is keyed on `${{ github.workflow }}-${{ github.ref }}` so the
workflows never cancel each other, and `cancel-in-progress` is `${{
github.event_name == 'pull_request' }}` so only PR runs are cancelled — pushes
to `main` still run to completion and each commit keeps its result.
Closes #235
## Verification
- Confirmed `zizmor.yml` and `api-spec-sync.yml` already declare
`concurrency` groups, so only the three missing workflows were changed.
- All three edited files parse as valid YAML and pass `prettier --check`.
- This is native GitHub Actions syntax — no new action, so nothing to review
against the ASF third-party Actions allowlist.
## Screenshots
Not applicable (non-UI change).
## Checklist
- [x] I did not hand-edit generated files under `src/app/api/`.
- [x] New component or service code uses the adapter boundary in
`src/app/core/adapters/` instead of direct browser globals or imperative
third-party APIs. (N/A — workflow-only change)
- [x] User-facing strings use translation keys. (N/A — no UI strings)
- [x] I added or updated tests appropriate to this change, or explained why
tests were not needed. (Workflow-only change; verified YAML parses and passes
Prettier. The repo's own `zizmor` and CodeQL `actions` analysis will lint the
new blocks on CI.)
- [x] UI workflow changes include suitable e2e coverage, including
real-backend testing where relevant. (N/A — no UI workflow changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
