DeathGun44 opened a new pull request, #6241: URL: https://github.com/apache/fineract/pull/6241
## Description Tier 1 of moving the savings and deposit integration tests onto the generated Feign client, so they call the API through typed models instead of raw JSON. It covers the 14 smaller savings classes. ## Production changes Limited to four Swagger files. **Most are additive** - optional fields that typed clients need but the schema does not describe: - savings product accounting mappings and overdraft fields - a transaction `note` - `transactionId` on two datatable responses - `withdrawalFeeForTransfers` The endpoints already accept and return these; only the documented shape changes. **One is not additive.** `SavingsAccountTransactionsSearchResponse.content` is a `List` rather than a `Set`. The endpoint returns a page ordered by the request's `orderBy`/`sortOrder`, and a set throws that order away in generated clients with no way to get it back. The response is a JSON array either way, so the wire format is unchanged. ## Backward compatibility The CI gate was reproduced locally against a spec built from the merge base. No breaking changes. The two specs differ in 52 places - 51 additions and one removal, the `uniqueItems` flag a list does not carry. ## Notes on a few choices - Each test class resets every global configuration to its default after each test and verifies it, so no test leaks configuration into the next. - The scheduler helper asserts that the run it awaited was triggered by the test itself and finished with status `success`, so a failed job cannot look like a passing one. The helper is shared with `FeignLoanTestBase`, so the loan suites get the same check. - The accrual accounting test gives every GL mapping its own account, so an assertion about one mapping cannot be satisfied by another. - Boolean checks on generated getters are null-safe, since those getters are nullable. - The batch endpoint answers 200 even when a sub-request fails, so the tests assert on each sub-request's own status code. ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [ ] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [ ] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [ ] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes - [ ] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). - [ ] If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately. Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
