Aman-Mittal commented on issue #180:
URL:
https://github.com/apache/fineract-backoffice-ui/issues/180#issuecomment-5227105464
Implemented in #253, now merged.
The group detail view is at
`src/app/features/groups/group-view.component.ts`, with four tabs — General,
Members, Committee, Notes — and the lifecycle and membership actions behind a
status- and permission-gated menu: activate, close, assign and unassign staff,
add and remove members, assign and unassign a committee role, and notes CRUD.
Covered by unit specs, a mocked e2e (`e2e/group-detail.spec.ts`) and a
real-backend e2e (`e2e/group-membership.spec.ts`) that drives the whole thing
through the UI with no API seeding.
Two things worth recording for whoever picks up the centre equivalent in
#181, because both cost real time here:
- **The generated API client is lossy for this resource.**
`GetGroupsGroupIdResponse` describes 7 fields; `GET
/groups/{id}?associations=all` returns 16. `clientMembers`, `groupRoles` and
the timeline are all absent from the generated type. The shape is declared once
in `group-detail.model.ts` rather than cast at each read.
- **`unassignRole` takes the assignment's own id, not the role id.** They
are different numbers and both are present on the row, so getting it wrong
fails only at runtime and only sometimes.
Closing as delivered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
