Aman-Mittal commented on issue #271: URL: https://github.com/apache/fineract-backoffice-ui/issues/271#issuecomment-5227149976
Rewrote this — the original framing was wrong. I filed it as "nothing stops an unsigned commit reaching `main`" and proposed adding a CI check. That premise was incorrect: branch protection already enforces signed commits, so unsigned work genuinely cannot be merged. A check would have added nothing except delivering the same refusal a little earlier. The real problem is narrower and cheaper to fix — the rule is enforced but never written down anywhere a contributor would look, so they only meet it after the work is finished and reviewed. The evidence I gathered still stands and now supports the right conclusion: both open community PRs carry unsigned commits, written by people who followed the documentation as it exists. Retitled, relabelled as documentation and a good first issue, and the CI-check proposal moved to an explicit out-of-scope note. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
