vidakovic commented on code in PR #5903:
URL: https://github.com/apache/fineract/pull/5903#discussion_r3748086218
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/config/SecurityConfig.java:
##########
@@ -397,6 +397,7 @@ public SecurityFilterChain filterChain(HttpSecurity http)
throws Exception {
.hasAnyAuthority(ALL_FUNCTIONS, ALL_FUNCTIONS_WRITE,
"UPDATE_HOOK")
.requestMatchers(API_MATCHER.matcher(HttpMethod.DELETE,
"/api/*/hooks/*"))
.hasAnyAuthority(ALL_FUNCTIONS, ALL_FUNCTIONS_WRITE,
"DELETE_HOOK")
+
Review Comment:
Careful with empty lines... if not really important then don't add, because
this makes the diff more complex and harder to handle with other PRs. We have
small header comments above each section, that should be enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
