AshharAhmadKhan opened a new pull request, #6256: URL: https://github.com/apache/fineract/pull/6256
JIRA https://issues.apache.org/jira/browse/FINERACT-2754 Problem When I removed the self-service feature in FINERACT-2480 (PR #5498), the accompanying changeset 0219_remove_self_service_feature.xml dropped five self-service related tables: m_selfservice_user_client_mapping m_selfservice_beneficiaries_tpt m_pocket_accounts_mapping m_pocket client_device_registration I missed request_audit_table in that cleanup. It backed the SelfServiceRegistration entity, but was mapped with @Table(name = "request_audit_table") instead of a name following the self/pocket convention used elsewhere, so it didn't show up when I was going through the codebase looking for self-service tables to drop. I came across it again while working on PR #6234 (FINERACT-2741, email column length standardization), where @adamsaghy flagged that request_audit_table had no backing entity or code reference. That's what prompted this follow-up. Fix Added a new Liquibase changeset (0246_drop_request_audit_table.xml, registered in changelog-tenant.xml) that drops request_audit_table with cascadeConstraints, following the same pattern as 0219. No changes required. SelfServiceRegistration.java, the only class that ever referenced this table, was already deleted in FINERACT-2480. Verification grep -rn "request_audit_table" across the full repo (excluding build/bin) returns only its own createTable, index, and foreign key definitions in 0001_initial_schema.xml. grep -rn "RequestAudit" across the full repo returns no results. git log --all -S"request_audit_table" confirms the table was created in afdc665b52 ("self service registration"), carried through the Flyway-to-Liquibase migration in 45bed0a05a, and never touched again until now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
