AshharAhmadKhan opened a new pull request, #6258: URL: https://github.com/apache/fineract/pull/6258
JIRA https://issues.apache.org/jira/browse/FINERACT-2755 Problem Five methods on TellerManagementReadPlatformServiceImpl have been unimplemented stubs returning null since the original Cash Management commit in 2013: getCashierData, findTellerTransaction, fetchTellerTransactionsByTellerId, getJournals, fetchTellerJournals. None of the three backing resource classes (CashierApiResource, TellerApiResource, TellerJournalApiResource) null-check the return value, so all five endpoints silently return HTTP 204 regardless of what is requested, including for resource IDs that do not exist. Fix CashierApiResource and TellerJournalApiResource have no other endpoints and are deleted entirely. TellerApiResource keeps its other working endpoints; only the three broken methods and their now-unused imports are removed from it. Raised on the dev list before removal, no objections received: https://lists.apache.org/thread/m972c6dgr46lob01smkryqwq6dxn7lms Verification All 15 existing TellerWritePlatformServiceJpaImplTest tests pass unchanged. compileJava and spotlessCheck both pass clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
