adamsaghy commented on code in PR #5946:
URL: https://github.com/apache/fineract/pull/5946#discussion_r3757519776
##########
integration-tests/src/test/java/org/apache/fineract/integrationtests/ExternalBusinessEventTest.java:
##########
@@ -191,9 +191,9 @@ public void verifyLoanChargeAdjustmentPostBusinessEvent01()
{
Assertions.assertEquals(1, ((List<?>)
loanChargePaidByList).size());
Map<?, ?> chargePaidBy = (Map<?, ?>) ((List<?>)
loanChargePaidByList).get(0);
Assertions.assertInstanceOf(Map.class, chargePaidBy);
- Assertions.assertEquals(111.0D, chargePaidBy.get("amount"));
- Assertions.assertEquals(chargeId.doubleValue(),
chargePaidBy.get("chargeId"));
- Assertions.assertEquals(transactionId.doubleValue(),
chargePaidBy.get("transactionId"));
+ Assertions.assertEquals(111.0D,
toDouble(chargePaidBy.get("amount")));
+ Assertions.assertEquals(chargeId.doubleValue(),
toDouble(chargePaidBy.get("chargeId")));
Review Comment:
Ids should not be casted to double...
##########
integration-tests/src/test/java/org/apache/fineract/integrationtests/ExternalBusinessEventTest.java:
##########
@@ -233,9 +233,9 @@ public void verifyLoanChargeAdjustmentPostBusinessEvent02()
{
Assertions.assertEquals(1, ((List<?>)
loanChargePaidByList).size());
Map<?, ?> chargePaidBy = (Map<?, ?>) ((List<?>)
loanChargePaidByList).get(0);
Assertions.assertInstanceOf(Map.class, chargePaidBy);
- Assertions.assertEquals(69.0D, chargePaidBy.get("amount"));
- Assertions.assertEquals(chargeId.doubleValue(),
chargePaidBy.get("chargeId"));
- Assertions.assertEquals(transactionId.doubleValue(),
chargePaidBy.get("transactionId"));
+ Assertions.assertEquals(69.0D,
toDouble(chargePaidBy.get("amount")));
+ Assertions.assertEquals(chargeId.doubleValue(),
toDouble(chargePaidBy.get("chargeId")));
+ Assertions.assertEquals(transactionId.doubleValue(),
toDouble(chargePaidBy.get("transactionId")));
Review Comment:
Ids should not be casted to double...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
