Aman-Mittal opened a new pull request, #348:
URL: https://github.com/apache/fineract-backoffice-ui/pull/348

   Unblocks #347. Upstream removed nine operations and the spec sync cannot 
build against them — this is the call-site half, landing separately so the 
regenerated client stays a clean diff. It is the outcome 
[ADR-0002](DOCS/adr/0002-automated-fineract-spec-sync.md) exists to surface.
   
   ## MIX (XBRL) reporting — removed
   
   [FINERACT-2670](https://issues.apache.org/jira/browse/FINERACT-2670) 
deprecates and removes the `fineract-mix` module. The MIX XBRL standard has 
been abandoned, and the implementation depended on `javax.script.ScriptEngine`, 
which modern Java no longer ships. `GET /mixtaxonomy`, `GET`/`PUT /mixmapping` 
and `GET /mixreport` go with it — and they were the entirety of the three 
screens, so there is nothing left for them to do.
   
   ## Cashier journals — removed
   
   [FINERACT-2755](https://issues.apache.org/jira/browse/FINERACT-2755) removes 
five teller/cashier read endpoints that *"have silently returned null since 
2013"* — never implemented, only mechanically touched since. `GET 
/cashiersjournal` backed this screen, so it has been showing nothing for its 
entire existence. The running platform agrees:
   
   ```
   GET /v1/cashiersjournal -> 204 No Content
   ```
   
   **The teller feature itself is untouched.** Only the journals screen goes; 
creating, settling and reviewing cashier transactions keep working.
   
   ## Provisioning criteria — fixed, not removed
   
   This one is a rename rather than a removal, and it turned out to be a live 
bug rather than only a compile error. The provisioning definitions now travel 
as `definitions`, and the old name is refused outright:
   
   ```
   POST /v1/provisioningcriteria  {"provisioningcriteria": [...]}
   → 400  The parameter provisioningcriteria is not supported
   
   POST /v1/provisioningcriteria  {"definitions": [...]}
   → 200  {"resourceId": 1}   ... and reads back under `definitions`
   ```
   
   So **saving an edit answers 400 today**. Those definitions are the 
criteria's actual provisioning rules — the percentage, ageing band and pair of 
GL accounts per category — and the form carries them without editing them, so 
the fix has to preserve them rather than drop the field. The payload is 
declared locally because the property is named differently either side of the 
sync and this must compile against both; reads accept either name, so an older 
instance still round-trips.
   
   ## Also
   
   Nav entries, routes and translations go with the screens, and the SPM group 
is no longer labelled "SPM & MIX" (`nav.spmMix` → `nav.spm`, in all three 
locales). `npm run lint:prune` drops the 40 suppressions belonging to the 
deleted files.
   
   ## Testing
   
   - **936 unit specs pass** — 8 fewer than main, exactly the specs for the 
deleted screens, plus 2 new ones pinning the provisioning round-trip: that an 
edit sends `definitions` and never `provisioningcriteria`, and that a response 
using the old name is still read.
   - `lint`, `format:check`, `i18n:check`, `check:icons` and `build` clean.
   - Every claim above was checked against a running Fineract rather than 
inferred from the spec diff — which is how the provisioning rename was found to 
be a defect rather than a rename to absorb quietly.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to