opensource-joe commented on issue #354: URL: https://github.com/apache/fineract-backoffice-ui/issues/354#issuecomment-5303519493
@Aman-Mittal flagging this one for you since it comes out of #233 and #338, which you reviewed and merged. The short version: the 44 buttons #338 left behind are not stragglers. `TooltipDirective` sets `aria-describedby` and never `aria-label`, and only while the tooltip is on screen, so the premise in #233 that the tooltip supplies the accessible name does not hold. That is written up above with the source and the re-derived counts. The only thing I need from you is the question at the end: **should the directive name the host itself, or should this be 44 more `[attr.aria-label]` attributes?** Being upfront so the answer is not skewed by workload: I already have the directive version written and passing (940 tests, `lint`, `lint:prune`, `format:check` all clean). I have deliberately not opened it as a PR, because #338 asked whether this follow-up was wanted at all and it would be poor form to answer my own question by just showing up with the code. So treat this purely as a preference call about shared behaviour across 256 call sites, not as an effort question. I am equally happy to throw that branch away and do the 44 attributes if you would rather keep the directive dumb. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
