Aman-Mittal commented on issue #257: URL: https://github.com/apache/fineract-backoffice-ui/issues/257#issuecomment-5318066295
Reopening — this was closed as completed on 15 Aug, but five sites matching the pattern in scope are still on `main`: ``` src/app/features/groups/group-action-dialog.component.ts:231 src/app/features/products/fixed-deposits/fixed-deposit-form.component.ts:416 src/app/features/products/recurring-deposits/recurring-deposit-form.component.ts:470 src/app/features/products/savings-account-transaction-form.component.ts:231 src/app/features/working-capital/loan-products/wc-loan-product-form.component.ts:681 ``` Reproduce with the narrower grep — the one in the description also matches `toIsoDate(new Date())` with no argument, which is today's date and not in scope: ```bash grep -rnE 'toIsoDate\(new Date\([A-Za-z0-9_.]+\[0\]' src/app --include=*.ts | grep -v spec ``` Two of the per-directory PRs the issue asked for did land — @YinkaMetrics's organization pass (301ba8e5, #333) and @Berserk-hub150's products one (d06d2e33, #345) — which is presumably why this looked finished. `products` has three sites left, and `groups` and `working-capital` were not in the original list of affected directories at all. Still a good first issue, and still one PR per feature directory: `groups`, `products`, `working-capital`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
