rymghosn opened a new pull request, #6285:
URL: https://github.com/apache/fineract/pull/6285
Tax configured on a loan charge (via a tax group) was only being applied
when the charge was collected at disbursement. When a charge was instead
paid on its own due date, on repayment, or transferred from a linked
savings account by the scheduled fee job, the tax component was silently
dropped and only the pre-tax base amount was charged/transferred.
This PR makes tax calculation consistent across all loan-charge payment
paths by applying TaxUtils.calculateChargeAmountWithTax(...) wherever a
charge amount is finalized for payment or transfer:
- LoanChargeWritePlatformServiceImpl – direct charge payment
(payLoanCharge)
- LoanWritePlatformServiceJpaRepositoryImpl – linked-account charge
amounts computed for disbursement-time account transfer
- LoanAccountDomainServiceJpa – charge paid as part of a
repayment-at-disbursement transaction
- TransferFeeChargeForLoansTasklet / TransferFeeChargeForLoansConfig – the
scheduled job that transfers due fee charges (including installment
fees) from a linked savings account, wired with a new LoanChargeRepository
dependency to look up the charge's tax group
- TaxUtils – adds getApplicableTaxComponentSummaries(...), used only for
the diagnostic log statements above (which components/percentages were
considered applicable for a given transaction date); no change to existing
tax math
TaxUtils.calculateChargeAmountWithTax(...) itself already existed and was
already in use for disbursement charges and savings-account charges —
this PR extends its use to the loan-charge-payment paths that were
bypassing it.
PR:(https://issues.apache.org/jira/browse/FINERACT-2764)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
