[
https://issues.apache.org/jira/browse/FINERACT-2768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Foo Developer updated FINERACT-2768:
------------------------------------
External issue URL: https://github.com/apache/fineract/pull/6289
> Tax Group cannot be edited once a linked Tax Component has ended
> ----------------------------------------------------------------
>
> Key: FINERACT-2768
> URL: https://issues.apache.org/jira/browse/FINERACT-2768
> Project: Apache Fineract
> Issue Type: Bug
> Components: Organization, User Management
> Reporter: Foo Developer
> Assignee: Foo Developer
> Priority: Major
> Labels: beginner, beginner-friendly
>
> TaxValidator.validateForTaxGroupUpdate() requires every
> taxComponents[].endDate submitted with a tax group update to be strictly
> after today —
> including for a component that is already linked to the group and has
> already ended, if it is simply resubmitted unchanged as part of editing
> something else about the group (e.g. renaming the group, or adding a new
> component to it).
>
>
> Because clients typically resubmit the full taxComponents array on update
> (to avoid dropping existing mappings), this makes a Tax Group
> permanently un-editable as soon as any one of its linked components passes
> its end date — even when that component's end date isn't being changed
> at all.
> Fix
>
>
>
> Restrict the future-end-date check to newly added components only (those
> with no existing mapping id). Existing mappings continue to go through
> validateTaxGroupEndDateAndTaxComponent(), which already correctly permits
> an unchanged end date to pass through and only rejects an actual
> attempt to modify it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
