adamsaghy commented on code in PR #6264: URL: https://github.com/apache/fineract/pull/6264#discussion_r3812509112
########## fineract-working-capital-loan/src/main/resources/db/changelog/tenant/module/workingcapitalloan/parts/0070_wc_period_payment_rate_change_eir_history.xml: ########## @@ -0,0 +1,46 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + +--> +<databaseChangeLog xmlns="http://www.liquibase.org/xml/ns/dbchangelog"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-4.3.xsd";> + + <!-- Snapshot of the values the amortization schedule computed for a period payment rate change: the EIR of the + segment the change opened plus the balance, discount, daily payment and term it re-amortizes. Nullable and + not backfilled - rate changes booked before this were never given a snapshot, and it cannot be reconstructed + from a schedule model that has since been rewritten. The EIR keeps 12 decimals because two rate changes only + differ from the ninth decimal onwards. --> + <changeSet author="fineract" id="wcl-0070-1"> + <preConditions onFail="MARK_RAN"> + <not> + <columnExists tableName="m_wc_loan_period_payment_rate_change" columnName="eir"/> + </not> + </preConditions> + <addColumn tableName="m_wc_loan_period_payment_rate_change"> + <column name="eir" type="DECIMAL(19,12)"/> Review Comment: Let's store annual effective interest rate, and use `DECIMAL(19,6)`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
