zhangxinyao88 opened a new pull request, #394: URL: https://github.com/apache/fineract-backoffice-ui/pull/394
## What and why Replace seven `window.confirm` calls on loan and client sub-screens with the app's `DialogService`. The dialogs use translated text, mark the action as destructive, and include values from the selected row so the user can verify the action before confirming. The six screens with existing specs now cover both confirmation and cancellation. Closes #231 ## Verification - `npm run lint` - `npm run i18n:check` - `npm run format:check` - `npm run check:icons` - `npm run check:a11y-names` - `npm run api:surface` - `npm run check:licenses` - `TZ=UTC npm test -- --watch=false` (1155 tests passed) - `npm run build` I did not exercise the UI against a live Fineract backend. ## Screenshots Not included. This change reuses the existing confirmation dialog without changing its appearance. ## Checklist - [x] I did not hand-edit generated files under `src/app/api/`. - [x] New component or service code uses the adapter boundary in `src/app/core/adapters/` instead of direct browser globals or imperative third-party APIs. - [x] User-facing strings use translation keys. - [x] I added or updated tests appropriate to this change, or explained why tests were not needed. - [ ] UI workflow changes include suitable e2e coverage, including real-backend testing where relevant. No e2e test was added because the change reuses the existing dialog and does not change routing or backend behavior. - [x] Commits are signed. See [Commit Signing](CONTRIBUTING.md#commit-signing) in CONTRIBUTING.md. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
