Aman-Mittal opened a new issue, #398:
URL: https://github.com/apache/fineract-backoffice-ui/issues/398

   Part of #395.
   
   ## Problem
   
   The dashboard tour's second step in 
`src/app/core/services/guidance.service.ts` declares:
   
   ```ts
   targetSelector: 'ul',
   ```
   
   That resolves through `document.querySelector('ul')`, which returns the 
**first** `<ul>` in the document — the sidebar's own `<ul class="nav-list">`, 
which renders before the dashboard's main content. The step's copy 
(`GUIDE.DASHBOARD_ENV_DESC`) describes the "System Overview & Status" card, so 
a first-time user is told about system status while the tour scrolls to and 
outlines the navigation menu.
   
   Separately, the tour's own controls in `guidance-tour.component.ts` are 
hardcoded English:
   
   ```html
   <ion-button fill="clear" color="medium" (click)="onExit()">Exit</ion-button>
   ```
   
   `Exit`, `Back`, `Next` and `Finish` all render in English regardless of the 
selected language — so the onboarding flow, of all things, ignores the language 
setting. Related to #251 and #388.
   
   ## Expected
   
   - The step targets the status card specifically (`.status-list`), not 
whatever `<ul>` happens to come first.
   - Tour controls resolve through `COMMON.*` translation keys.
   
   ## Notes
   
   Reproduce by starting the dashboard tour and advancing one step. A 
regression test needs to assert the highlighted element, not merely that the 
tour advanced.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to