Aman-Mittal opened a new issue, #407:
URL: https://github.com/apache/fineract-backoffice-ui/issues/407

   Part of #403. **Good first issue** — 10 specs in each of two areas, all 
mechanical.
   
   ## What to do
   
   `src/app/features/organization/` (10) and 
`src/app/features/working-capital/` (10) still run on the deprecated Karma 
runner. One PR or two — say which you are taking in a comment.
   
   ```bash
   node scripts/codemod-jasmine-to-vitest.mjs $(node -p 
"require('./karma-baseline.json').specs.filter(f=>/^src\/app\/features\/(organization|working-capital)\//.test(f)).join('
 ')")
   npm run test:unit
   node scripts/check-test-runner.mjs --write
   npm run lint:prune && npm run format
   npm test -- --watch=false
   ```
   
   All 20 convert cleanly — the codemod reports `0 left for a human` for both 
areas.
   
   ## Acceptance criteria
   
   - [ ] No `.spec.ts` files remain under the area(s) you took
   - [ ] `npm run test:unit` and `npm test -- --watch=false` both pass
   - [ ] Karma total + Vitest total unchanged — quote both in the PR
   - [ ] `karma-baseline.json` updated in the same commit
   - [ ] `npm run lint` and `npm run format:check` clean
   
   ## Things that trip people up
   
   - Run `npm run lint:prune` after the rename — `eslint-suppressions.json` is 
keyed by path.
   - Some working-capital specs were migrated already, so expect a mix of 
`.test.ts` and `.spec.ts` in that folder. Only the `.spec.ts` files are in 
scope; the baseline is the authority on which remain.
   - Migrate as-is; open a separate issue for anything that looks wrong.
   
   Background: 
[`DOCS/adr/0004-vitest-migration.md`](DOCS/adr/0004-vitest-migration.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to