Aman-Mittal opened a new issue, #409:
URL: https://github.com/apache/fineract-backoffice-ui/issues/409
Part of #403. **Good first issue** — the largest single area. 38 of the 39
convert mechanically; one needs a person, and you can leave that one behind.
## What to do
```bash
node scripts/codemod-jasmine-to-vitest.mjs $(node -p
"require('./karma-baseline.json').specs.filter(f=>f.startsWith('src/app/features/products/')).join('
')")
npm run test:unit
node scripts/check-test-runner.mjs --write
npm run lint:prune && npm run format
npm test -- --watch=false
```
The codemod will convert 38 and report **1 left for a human** —
`deposit-account-view.component.spec.ts`, which uses `flush()`. Leave it on
Karma; it is covered by #409. Migrating 38 of 39 is a complete, mergeable piece
of work.
## Splitting this up
39 files is a big diff. It is entirely reasonable to take this in two or
three PRs by subdirectory — say so in a comment so nobody duplicates your work.
Suggested split:
- `src/app/features/products/accounting/` and
`src/app/features/products/charges/`
- `src/app/features/products/interest-rate-charts/` and the deposit/savings
product screens
- everything else under `src/app/features/products/`
## Acceptance criteria
- [ ] Only the one `flush()` spec remains as `.spec.ts` under
`src/app/features/products/` (or your stated subset is done)
- [ ] `npm run test:unit` and `npm test -- --watch=false` both pass
- [ ] Karma total + Vitest total unchanged — quote both in the PR
- [ ] `karma-baseline.json` updated in the same commit
- [ ] `npm run lint` and `npm run format:check` clean
## Things that trip people up
- Run `npm run lint:prune` after the rename — `eslint-suppressions.json` is
keyed by path, and product screens carry a lot of recorded `| translate`
violations. The total count should not change, only the paths.
- Migrate as-is. Product screens have some of the oldest specs in the repo
and it is tempting to tidy them; please don't in the same diff.
Background:
[`DOCS/adr/0004-vitest-migration.md`](DOCS/adr/0004-vitest-migration.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
