Aman-Mittal opened a new issue, #411:
URL: https://github.com/apache/fineract-backoffice-ui/issues/411
Part of #403. **Good first issue** — the smallest possible starting point.
Several areas have only one or two specs, so you can take a single folder, get
a PR merged, and see the whole workflow end to end before deciding whether to
take a bigger batch.
## What to do
These areas each have a handful of specs left on the deprecated Karma runner:
| Area | Specs |
| --- | --- |
| `features/spm` | 5 |
| `features/calendars` | 3 |
| `features/meetings` | 3 |
| `features/settings` | 3 |
| `features/tellers` | 3 |
| `features/login`, `features/security`, `features/tasks`,
`features/transfers`, `layout` | 2 each |
| `features/centers`, `features/reporting` | 2 each (1 needs a person — see
below) |
| `features/dashboard`, `features/errors`, `features/interop`,
`features/profile` | 1 each |
**Take one area, or several — say which in a comment** so two people do not
pick the same one.
```bash
AREA=spm # or calendars, meetings, settings, tellers, login, ...
node scripts/codemod-jasmine-to-vitest.mjs $(node -p
"require('./karma-baseline.json').specs.filter(f=>f.startsWith('src/app/features/'+process.env.AREA+'/')).join('
')")
npm run test:unit
node scripts/check-test-runner.mjs --write
npm run lint:prune && npm run format
npm test -- --watch=false
```
One spec in `features/centers` and one in `features/reporting` use `flush()`
and will be skipped by the codemod — leave them, they are covered by #410.
## Acceptance criteria
- [ ] No `.spec.ts` files remain in the area(s) you took, except any the
codemod reported as needing a person
- [ ] `npm run test:unit` and `npm test -- --watch=false` both pass
- [ ] Karma total + Vitest total unchanged — quote both in the PR
- [ ] `karma-baseline.json` updated in the same commit
- [ ] `npm run lint` and `npm run format:check` clean
## Things that trip people up
- Run `npm run lint:prune` after the rename — `eslint-suppressions.json` is
keyed by path. The total suppression count should not change, only the paths.
- Migrate as-is; open a separate issue for anything that looks wrong.
- A one-file PR is a completely acceptable contribution here. The batches
exist to keep diffs reviewable, not to set a minimum.
Background:
[`DOCS/adr/0004-vitest-migration.md`](DOCS/adr/0004-vitest-migration.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
