Aman-Mittal commented on issue #395: URL: https://github.com/apache/fineract-backoffice-ui/issues/395#issuecomment-5346308007
Closing — all six sub-issues are complete, delivered by #408 (merged as `23705cd3`), with the two follow-up defects it exposed fixed in #412. | Sub-issue | Delivered by | Evidence | | --- | --- | --- | | #396 WC loan read-only | `wc-loan-view` gains breach / near-breach / originator tabs, three action-form components on routes guarded by `UPDATE_WORKINGCAPITALLOAN` | `npm run check:route-permissions` — 309 screens, 274 gated, guard order and nav visibility agree | | #397 Interop repayment sent with no body | Spec re-synced (1472 → 1475 schemas); the call now sends `dateFormat` + `locale` | `public/api/fineract.provenance.json` records image digest `sha256:dd7721fa…`; `npm run verify-api-client` clean | | #398 Tour highlighted the sidebar | `targetSelector` moved from `'ul'` to `.status-list`; tour buttons routed through `COMMON.*` | `e2e/guidance-tour-dashboard.spec.ts` asserts the highlighted element, not merely that the tour advanced | | #399 Search click swallowed by blur timeout | Result items `preventDefault()` on `mousedown`, so the searchbar never blurs for a result click | `header.component.test.ts`, plus `e2e/global-search-nav-shortcuts.spec.ts` | | #400 RBAC coverage gaps | `e2e/rbac-multi-permission.spec.ts` — OR-semantics routes, `ALL_FUNCTIONS_READ` against Fineract's real catalogue, a second action-level gate, reload persistence | Registered in `BACKEND_SPECS`; every refusal asserted both as Access Denied **and** as a 403 from Fineract | | #401 No repeatable demo dataset | `npm run seed:demo-data`, its own `demo-seed` Playwright project | Composed from existing `seed-api.ts` helpers; not a member or dependency of `BACKEND_SPECS`, so it cannot run as a side effect of `--project=backend` | Suite state at merge: **Karma 921 + Vitest 270 = 1191**, unchanged from before the branch, so nothing was lost. ### Two defects this epic's own CI gates caught after merge Worth recording, because both are the gates working rather than noise, and both are fixed in #412: - `unlink-outline` on the originator detach control was never added to `APP_ICONS`. Ionic resolves an unregistered name by fetching an SVG over the network, which the production CSP blocks (#360), so the control rendered as blank space with nothing in the console. - `api-surface.json` did not record the eight operations the new screens call — 8 added, 0 removed, 142 → 145 services, 564 → 572 operations. ### Deliberately still open - Editing and deleting existing delinquency / breach / near-breach actions — create and list only, as scoped above. - #232, Working Capital screens still using the browser's native `confirm()`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
