Dhanno98 opened a new pull request, #6306: URL: https://github.com/apache/fineract/pull/6306
## Description Part of [FINERACT-2165](https://issues.apache.org/jira/browse/FINERACT-2165) system-wide migration of integration tests to fineract-client-feign. Migrates `SavingsAccountChargeRoundingTest` from the legacy Fineract client to the Fineract Feign Client. The migration: - Updates savings product and savings account setup to use the Feign test helpers. - Migrates savings account charge creation, application, and retrieval to the Feign client. - Migrates savings account deposits, withdrawals, and account retrieval to the Feign client. - Adds the required savings charge and business-date helpers to the Feign savings test infrastructure. - Preserves the existing test scenarios and assertions without changing their intended behavior. All existing `SavingsAccountChargeRoundingTest` scenarios pass after the migration. ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [ ] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [ ] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [ ] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes - [ ] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). - [ ] If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately. Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
