Aman-Mittal opened a new issue, #420:
URL: https://github.com/apache/fineract-backoffice-ui/issues/420

   Good first issue. Self-contained, one file, no backend needed.
   
   ## What is wrong
   
   `src/app/features/accounting/accounting.routes.ts` declares **28 routes and 
not one `title`**. Two things follow from that, both visible without any setup:
   
   1. **No breadcrumb.** The trail added in #419 is derived from each activated 
route's `title`. With no title on the child route, only the section contributes 
a crumb, and the component hides a one-crumb trail — so the whole Accounting 
section renders with no breadcrumb at all.
   2. **Every Accounting screen has the same browser-tab title.** 
`TranslatedTitleStrategy` falls back to the nearest ancestor that has one. 
Journal Entries and Chart of Accounts — different screens — both title the tab 
`Accounting · Fineract`, so browser history and a row of open tabs cannot tell 
them apart.
   
   ## Evidence
   
   Captured against a live Fineract instance.
   
   Journal Entries — no breadcrumb above the content, tab title `Accounting · 
Fineract`:
   
   ![Journal entries with no 
breadcrumb](https://raw.githubusercontent.com/Aman-Mittal/fineract-backoffice-ui/assets/issue-screenshots/gap-journal-entries.png)
   
   For contrast, Loan Products, whose route file does set titles — note 
`Products › Loan Products` above the card:
   
   ![Loan products with a 
breadcrumb](https://raw.githubusercontent.com/Aman-Mittal/fineract-backoffice-ui/assets/issue-screenshots/ok-loan-products.png)
   
   ## The fix
   
   Add a `title` to each route in `accounting.routes.ts`, pointing at a 
translation key — the same key the screen's own heading already uses, wherever 
one exists.
   
   ```ts
   {
     path: 'journal-entries',
     canActivate: [authGuard, permissionGuard],
     data: { permissions: 'READ_JOURNALENTRY' },
     title: 'ACCOUNTING.JOURNAL_ENTRIES',   // <-- add this
     loadComponent: () => import('./journal-entries-list.component')...
   }
   ```
   
   `src/app/features/products/products.routes.ts` (65 routes, all titled) is 
the model to copy.
   
   If a key does not exist yet, add it to `src/assets/i18n/en.json` under the 
section it belongs to. `npm run i18n:check` fails on a key that is referenced 
but missing, so it will tell you.
   
   ## Verifying
   
   ```bash
   npm start
   ```
   
   Open an Accounting screen. The breadcrumb should appear above the content 
and the browser tab should name the screen rather than the section. `npm run 
lint && npm run i18n:check` should stay green.
   
   ## Scope
   
   Only `accounting.routes.ts`. The other untitled route files are separate 
issues so several people can work in parallel without conflicting — the full 
list is on #355.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to