slegarraga commented on PR #427: URL: https://github.com/apache/fineract-backoffice-ui/pull/427#issuecomment-5384811496
Done on both counts, thank you for the careful checks! **Prettier** `npm run format:check` is clean across the whole repo now (pushed as `9d3527a`, force-pushed over the previous SHA with an identical tree). The two warnings were exactly the files this PR touches, `src/assets/i18n/hi.json` and `src/assets/i18n/ko.json`; both reformatted and nothing else changed. **Before / after screenshots** (before on the left, after on the right, captured against a mocked Fineract backend the same way the e2e specs do): | Route | Before \| After | | --- | --- | | `/security/users` |  | | `/security/users/create` |  | | `/security/roles` |  | | `/security/audits` |  | On main every security page inherits the section title, so all four tabs read "Security · Fineract" and no breadcrumb trail renders at all. With this PR each page gets its own tab title ("Users · Fineract", "Create User · Fineract", "Roles · Fineract", "Audit Logs · Fineract") and the breadcrumb renders `Security > <page>` with the ancestor crumb clickable. **Videos** (full walkthrough: login, then visiting all four routes): * [Side-by-side comparison](https://raw.githubusercontent.com/slegarraga/fineract-backoffice-ui/pr-427-evidence/side-by-side.mp4) * [Before only](https://raw.githubusercontent.com/slegarraga/fineract-backoffice-ui/pr-427-evidence/before.mp4) * [After only](https://raw.githubusercontent.com/slegarraga/fineract-backoffice-ui/pr-427-evidence/after.mp4) These were produced by driving the real app headlessly through sign-in into the four security routes, reading `document.title` and the rendered breadcrumb nav at each stop, so the captures reflect actual runtime behaviour rather than mockups. **Verification on the pushed SHA (`9d3527a`)** * `npm run format:check`: all matched files use Prettier code style * `npm run i18n:check`: 1618 referenced keys checked against `en.json`, no missing keys * `npm run lint`: exit 0 * Unit tests: 886 of 898 passing, with an identical failure set to `origin/main` (the 12 failures are pre-existing on main in unrelated date-formatting form components) **Commit signing**: the commit is GPG-signed, fingerprint `51B659FE 265609B4 6D311AC3 9A1DE9A6 772873B9`. The public key still needs to be attached to my GitHub account, which is an interactive settings step on my side that keeps slipping; sorry for the wait on that. Once attached, GitHub marks the existing commit VERIFIED retroactively, no further push needed. Happy to adjust anything else! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
