Aman-Mittal commented on issue #410: URL: https://github.com/apache/fineract-backoffice-ui/issues/410#issuecomment-5386332774
> [@Aman-Mittal](https://github.com/Aman-Mittal), I checked my devbox, and I think the skip list is overcounting. > > The blocker at scripts/codemod-jasmine-to-vitest.mjs:68 is /\bflush(/. \b matches after a dot, so it catches req.flush() from HttpTestingController. Nothing in the repo imports flush from @angular/core/testing, so the files listed under flush() are HTTP mocks rather than zone work. Line 67 does the same to jasmine.clock().tick() in tooltip.directive. > > Adding (?<!.) to both takes the skip list from 30 to 22. (It is at 30 now rather than 19.) > > That is not 8 free files, though. I converted all 8, and only 4 compile: auth.service, config.service, center-view, and group-view have the same test counts as their Karma originals, and the suite is green at 560. The other 4 use fail(), expect().nothing() and .calls.mostRecent(), which the codemod has no rules for. So they were right to skip, just for the wrong reason. > > Happy to send the regex fix and those 4 conversions as a small PR if that is useful. Either way, the genuinely manual set here looks like the 5 fakeAsync files plus the 2 done() interceptors. Sure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
