Whxuan0701 opened a new pull request, #449:
URL: https://github.com/apache/fineract-backoffice-ui/pull/449

   ## Summary
   
   - remove the deleted `FloatingRateRequest` dependency from the floating-rate 
form
   - derive create and update payload types from the generated service methods
   - keep the form state non-nullable and reject incomplete rate-period rows 
before submission
   
   Apache Fineract's generated client now exposes separate request models for 
creating and updating
   floating rates. This change keeps the consumer compatible with the current 
client and with the
   model changes introduced by #447, without hand-editing generated files.
   
   ## Validation
   
   - `npm ci`
   - `npm run format:check`
   - `npm run lint`
   - `npm run api:surface`
   - `npm run verify-api-client`
   - `npm run build`
   - `npm test -- --watch=false --browsers=ChromeHeadless 
--include=src/app/features/products/floating-rates/floating-rate-form.component.spec.ts`
   - `npm run build` on a temporary worktree containing the generated client 
from #447
   
   The build reports the repository's existing header component style-budget 
warning. The focused
   Karma run passes all 3 tests. The full Vitest command is currently 
environment-sensitive under
   Node 26 because its file-backed `localStorage` database is shared by 
parallel workers; with the
   workaround, 745 of 746 tests pass and the remaining failure is the SQLite 
lock in an unrelated
   navigation test.
   
   Fixes #448
   
   OpenAI Codex (GPT-5) on behalf of Weihao Xuan (Whxuan0701)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to