opensource-joe opened a new pull request, #450: URL: https://github.com/apache/fineract-backoffice-ui/pull/450
Closes part of #410: the five specs the corrected skip list releases. The genuinely manual set is untouched. ## The skip list was over-counting `/\btick\(/` and `/\bflush\(/` match after a dot, so `req.flush()` on an `HttpTestingController` request and `jasmine.clock().tick()` both tripped them. Nothing in the repo imports `flush` from `@angular/core/testing`. Anchoring with `(?<!\.)` takes the list from **30 to 25**, and the remaining reasons now name the real blocker. Anchoring exposed two things, both fixed here: - **`fail` and `expect().nothing()` were masked** by the unanchored patterns. Without adding them as skip triggers, anchoring starts emitting specs that do not compile. `fail` is matched in call and reference position only, never as a bare word: two specs use it in prose comments and must still convert. - **Renaming a spec orphaned its lint suppressions.** `eslint-suppressions.json` is path-keyed, so `lint:prune` deleted the stranded entries and the violations came back as errors. The rename now carries them across. Also `.calls.mostRecent().args` was matched on one line only, so prettier line-wrapping defeated it. ## The five specs None changed timing model, which is the point: they were never zone tests. Counts unchanged. `auth.service` 22 · `config.service` 14 · `center-view` 13 · `group-view` 7 · `deposit-account-view` 20 ## Verification Clean checkout of `main` at `b1d9280`: - `npm run test:unit`: 822 tests across 142 files, 0 failures - Karma: 551 of 551 SUCCESS - `npm run lint`, `lint:prune`, `format:check`: all clean - Ratchet: 99 remaining to 94 ## Still manual The 5 `fakeAsync` files, the 2 `done()` interceptors, and `fail` / `expect().nothing()` in `error.interceptor`, `loading.interceptor` and `report-execution.service`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
