DeathGun44 commented on code in PR #6324:
URL: https://github.com/apache/fineract/pull/6324#discussion_r3846544867
##########
config/checkstyle/checkstyle.xml:
##########
@@ -101,6 +101,14 @@
<property name="forbiddenImportsExcludesRegexp" value="" />
<message key="forbid.certain.imports" value="Use
''java.nio.charset.StandardCharsets'' instead of ''{0}''" />
</module>
+ <!-- Forbid REST Assured in the Feign integration tests; use the
generated Feign client -->
+ <module
name="com.github.sevntu.checkstyle.checks.coding.ForbidCertainImportsCheck">
Review Comment:
Fixed - I've switched the rule to stock Checkstyle (IllegalImport scoped by
a SuppressionSingleFilter with a matching id). This PR now adds no sevntu usage
at all; the diff is two standard modules. Verified it behaves identically: same
5 violations on develop, 0 after #6321, and identical per-file counts across
the whole integration-tests tree.
On sevntu more broadly - it's used in three places that predate this branch,
and checkstyle itself carries the same LGPL-2.1 licence. Both are build-time
only, so ASF policy allows it ("using a GPL'ed tool during the build is okay").
If you'd like the project to move off it regardless, I'm happy to share what I
found on replacements, but it seems better suited to its own ticket than this
one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
