opensource-joe opened a new issue, #452: URL: https://github.com/apache/fineract-backoffice-ui/issues/452
Split out of #442. #207 bumps `@ngx-translate/core` to v18. That is a major, and today it would touch 317 files. This is the work that makes it touch three. **Drop a dead dependency first.** `@ngx-translate/http-loader` is still in `package.json` and nothing imports it. #437 replaced it; only a comment at `app.config.ts:132` remains. **The boundary exists on paper only.** ADR-0003 puts ngx-translate behind the `I18N` token, but 317 files import `@ngx-translate/core` directly and only 3 are in `core/adapters/`. Lint already forbids it; the other 312 sit in `eslint-suppressions.json`. Note the templates are inline in the `.ts` files. Order: 1. `| translate` to `| appTranslate`, dropping `TranslateModule` from each component's imports. 2,860 sites, 604 already done. **Not a good first issue**, unlike #442. 2. Move the 40 `TranslateService` injections onto the `I18N` token. 3. Then #207, confined to `ngx-translate-i18n.adapter.ts`, `deployment-translate.loader.ts` and `app.config.ts`. Acceptance: `http-loader` gone, no `@ngx-translate/core` import outside the adapter, no `no-restricted-imports` suppressions left for it, and lint, both unit suites and the `mocked` and `mobile` Playwright projects green. Counts measured on `main` at `b1d9280`. Background: `DOCS/adr/0003-adapter-boundary.md`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
