AmandaKeay opened a new pull request, #455: URL: https://github.com/apache/fineract-backoffice-ui/pull/455
## What and why Replaces the native `window.confirm()` dialog with the app's styled `DialogService.confirm()` in the calendars and meetings delete flows, matching the pattern already used elsewhere in the app (e.g. `codes-list.component.ts`). This gives these two remaining screens a translated, themed, destructive-marked confirmation instead of the browser's untranslatable, unstyled dialog. Closes #232 ## Verification - Ran `npm run lint`, `npm run i18n:check`, and `npm test` — all passing - Updated unit tests in `calendars-list.component.spec.ts` and `meetings-list.component.spec.ts` to mock `DialogService.confirm()` instead of `window.confirm` - Manually verified the styled confirm modal renders correctly with real translated text (title, message with interpolated name/date, destructive styling) using a temporary preview test with the real `DialogService` and `TranslateModule` - Exercised with mocks only; did not test against a real Fineract backend ## Screenshots Before: <img width="1202" height="358" alt="Before" src="https://github.com/user-attachments/assets/448bb106-5004-40ce-bac2-e3fdcfaf75f8"; /> After: <img width="1372" height="870" alt="After" src="https://github.com/user-attachments/assets/e4480b06-a695-4541-9e26-88c1dc43b1b8"; /> ## Checklist - [x] I did not hand-edit generated files under `src/app/api/`. - [x] New component or service code uses the adapter boundary in `src/app/core/adapters/` instead of direct browser globals or imperative third-party APIs. - [x] User-facing strings use translation keys. - [x] I added or updated tests appropriate to this change, or explained why tests were not needed. - [ ] UI workflow changes include suitable e2e coverage, including real-backend testing where relevant. — Not added: this is a UI-only confirmation dialog swap with existing unit test coverage; no new user flow to cover with e2e. - [x] Commits are signed — see [Commit Signing](CONTRIBUTING.md#commit-signing) in CONTRIBUTING.md. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
