ruzeynalov commented on PR #6299: URL: https://github.com/apache/fineract/pull/6299#issuecomment-5424784579
Thanks — pushed `74a2c616cf` (amended e2e commit) with both non-blocking points addressed: - **WC-specific helper**: the tenant-date probe/assert moved out of `BusinessDateHelper` into a new `WorkingCapitalTenantDateHelper`; `BusinessDateHelper` is generic again and the two WC stepdefs inject the new helper. - **`isNotEqualTo(storedBusinessDate)`**: kept, but reframed as an explicit precondition (`assertThat(storedBusinessDate).isNotIn(before, after)` with a self-explaining message). Rationale: the probe (charge-off template) and the stamp both resolve through `DateUtils.getBusinessLocalDate()`, so a regression that returned the stored row while the config is off would move both together and `isIn(before, after)` alone would still pass — the inequality is the only assertion that proves the fallback path actually ran. The stub date is 01 Jan 2026, already in the past, so the calendar collision cannot occur going forward; if it ever did, the failure now states exactly why. Both isolated scenarios are green locally (2/2). The `createdDate` restoration for the API-compat check is not part of this push and follows separately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
