adamsaghy commented on code in PR #6321:
URL: https://github.com/apache/fineract/pull/6321#discussion_r3863192114
##########
integration-tests/src/test/java/org/apache/fineract/integrationtests/ExternalIdSupportIntegrationTest.java:
##########
@@ -664,13 +667,13 @@ public void negativeTest() {
final Account expenseAccount =
accountHelper.createExpenseAccount("extIdExpense");
final Account overpaymentAccount =
accountHelper.createLiabilityAccount("extIdOverpayment");
- final String loanProductJSON = new
LoanProductTestBuilder().withPrincipal("1000").withRepaymentTypeAsMonth()
+ final PostLoanProductsRequest loanProductRequest = new
LoanProductTestBuilder().withPrincipal("1000").withRepaymentTypeAsMonth()
.withRepaymentAfterEvery("1").withNumberOfRepayments("1").withRepaymentTypeAsMonth().withinterestRatePerPeriod("0")
.withInterestRateFrequencyTypeAsMonths().withAmortizationTypeAsEqualPrincipalPayment().withInterestTypeAsFlat()
.withAccountingRulePeriodicAccrual(new Account[] {
assetAccount, incomeAccount, expenseAccount, overpaymentAccount })
.withDaysInMonth("30").withDaysInYear("365").withMoratorium("0", "0")
-
.withFeeAndPenaltyAssetAccount(assetFeeAndPenaltyAccount).build(null);
- final Integer loanProductID = getLoanProductId(loanProductJSON);
+
.withFeeAndPenaltyAssetAccount(assetFeeAndPenaltyAccount).buildRequest(null);
+ final Integer loanProductID = getLoanProductId(loanProductRequest);
Review Comment:
This should be Long, no?
##########
integration-tests/src/test/java/org/apache/fineract/integrationtests/ExternalIdSupportIntegrationTest.java:
##########
@@ -824,14 +827,14 @@ public void loan() {
PostDelinquencyBucketResponse delinquencyBucketResponse =
DelinquencyBucketsHelper
.createBucket(new
DelinquencyBucketRequest().name(Utils.randomStringGenerator("DLQ_B_",
10)).ranges(rangeIds));
- final String loanProductJSON = new
LoanProductTestBuilder().withPrincipal("1000").withRepaymentTypeAsMonth()
+ final PostLoanProductsRequest loanProductRequest = new
LoanProductTestBuilder().withPrincipal("1000").withRepaymentTypeAsMonth()
.withRepaymentAfterEvery("1").withNumberOfRepayments("1").withRepaymentTypeAsMonth().withinterestRatePerPeriod("0")
.withInterestRateFrequencyTypeAsMonths().withAmortizationTypeAsEqualPrincipalPayment()
.withInterestTypeAsDecliningBalance().withAccountingRuleAsNone()
.withInterestCalculationPeriodTypeAsRepaymentPeriod(true).withDaysInMonth("30").withDaysInYear("365")
.withMoratorium("0",
"0").withDelinquencyBucket(delinquencyBucketResponse.getResourceId())
-
.withInArrearsTolerance("1001").withMultiDisburse().withDisallowExpectedDisbursements(true).build(null);
- final Integer loanProductID = getLoanProductId(loanProductJSON);
+
.withInArrearsTolerance("1001").withMultiDisburse().withDisallowExpectedDisbursements(true).buildRequest(null);
+ final Integer loanProductID = getLoanProductId(loanProductRequest);
Review Comment:
This should be Long, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
