Cocoa-Puffs commented on PR #6359: URL: https://github.com/apache/fineract/pull/6359#issuecomment-5477487994
> Note: Overall it is a good improvement and optimization for the tests. However the previous UC1 and UC4 cases added charges several months after disbursement and asserted three or five breach periods. The new January 6 due date is inside the first period, which spans January 1 through February 28, so the schedule does not need to be extended at all. This means that a regression that fails to generate intervening breach periods or fails to extend a schedule to a later charge date could pass this feature undetected. I have checked the WC breach and near breach feature files. C74544, and C74546 in WorkingCapitalBreachSchedule.feature already cover the intervening breach period generation by the COB. Since this feature is testing behaviour when charges are applied after maturity I thought that aspect of these tests can be removed. I have modified UC1 and UC4 so they again test the behaviour of a post-maturity charge extending the schedules. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
