adamsaghy commented on code in PR #6340:
URL: https://github.com/apache/fineract/pull/6340#discussion_r3902763271
##########
.github/workflows/build-quality-checks.yml:
##########
@@ -300,3 +300,53 @@ jobs:
- name: Run Spotless
run: ./gradlew spotlessCheck
+
+ licenses:
+ if: github.event_name == 'pull_request'
+ runs-on: ubuntu-24.04
+ timeout-minutes: 45
+
+ env:
+ TZ: Asia/Kolkata
+ DEVELOCITY_ACCESS_KEY: ${{ secrets.DEVELOCITY_ACCESS_KEY }}
+ BASE_SHA: ${{ github.event.pull_request.base.sha }}
+
+ steps:
+ # This job diffs the PR head against its target branch, so it needs
Review Comment:
If compile only Category X dependencies are not a problem at the moment, i
see no reason to flag the new ones as problems. Am I missing something here?
If license check is important, i guess we need something which builds
fineract jar and checks whether it contains any Category X dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
