SamaSVM opened a new pull request, #6371: URL: https://github.com/apache/fineract/pull/6371
## Description Removes unused (dead) code across multiple modules, including classes and members that are no longer referenced anywhere in the codebase. This includes: * **Unused exception classes** — exceptions that are never thrown, such as `RateAlreadyExistException`, `GroupLevelNotFoundException`, `PasswordMustBeDifferentException`, `JobInProcessExecution`, and similar exception types with no throw sites. * **Unused commands and DTOs** — obsolete classes such as `UndoStateTransitionCommand`, `UpdateLoanOfficerCommand`, `ClientNoteCommand`, `LoanConvenienceData`, and `GuarantorDTO`. * **Repository methods with no callers** — orphaned query methods removed from active repository interfaces such as `LoanRepository`, `TellerRepository`, and `ExternalAssetOwnerTransferRepository`, while keeping the repositories themselves. * **Unused serializers and content processors** — components such as `MoneySerializer`/`MoneyDeserializer`, `GzipEncoderContentProcessor`/`GzipDecoderContentProcessor`, `SizeContentProcessor`, and `FileContentDetector`, along with their now-orphaned unit tests. * **Orphaned fields and methods in active classes** — unused members removed from otherwise active classes such as `Staff`, `Charge`, `TellerData`, `TaxComponent`, `FloatingRateData`, `LoanCollateral`, and `CollateralAssembler`. ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [ ] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [ ] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [ ] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes - [ ] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). - [ ] If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately. Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
