Aman-Mittal commented on code in PR #476:
URL:
https://github.com/apache/fineract-backoffice-ui/pull/476#discussion_r3923929589
##########
.github/workflows/ci.yml:
##########
@@ -231,17 +231,19 @@ jobs:
restore-keys: |
${{ runner.os }}-angular-test-
- name: Run Tests with Coverage
+ # The legacy runner has no work once the Karma baseline reaches zero.
Its complete
+ # removal, including its configuration and dependencies, follows in a
separate change.
+ if: ${{ hashFiles('src/**/*.spec.ts', 'projects/**/*.spec.ts') != '' }}
run: npm run test -- --watch=false --browsers=ChromeHeadless
--code-coverage
- # The migrated half of the suite. Runs as its own step rather than
replacing the one
- # above because both runners are live until the Karma baseline reaches
zero — a green
- # build has to mean both are green, or a migrated spec could rot
unnoticed.
+ # During migration this complements Karma; after the baseline reaches
zero it is the
+ # complete unit suite.
- name: Run migrated tests on Vitest
run: npm run test:unit
- name: Run microfrontend tests on Vitest
run: npm run test:mfe
- name: Upload Coverage Report
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a
# v7.0.1
- if: always()
+ if: ${{ always() && hashFiles('src/**/*.spec.ts',
'projects/**/*.spec.ts') != '' }}
Review Comment:
Why this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
