vidakovic commented on code in PR #6387: URL: https://github.com/apache/fineract/pull/6387#discussion_r3980023520
########## fineract-provider/src/test/java/org/apache/fineract/infrastructure/core/boot/FineractApplicationLifecycleLoggerTest.java: ########## @@ -0,0 +1,53 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.fineract.infrastructure.core.boot; + +import static org.assertj.core.api.Assertions.assertThat; + +import org.junit.jupiter.api.Test; +import org.springframework.mock.env.MockEnvironment; + +public class FineractApplicationLifecycleLoggerTest { Review Comment: This is just a test for the sake of having a test... do we even test here anything relevant... when I read this you tell me basically that you don't trust the Spring Framework to provide the most basic of properties when we need them. To that I answer: why not test everything else from the framework? I think it's not too exaggerated to assume that the Spring community - that does this 24/7 - has us covered here. Please remove, noise. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
