Cocoa-Puffs commented on PR #6417: URL: https://github.com/apache/fineract/pull/6417#issuecomment-5631308849
@adamsaghy I have addressed the concerns. 1 + 4: `testNotDueInterestStaysFlatDespiteContinuingDailyAccrualAfterReAge` has been renamed to `notDueInterestTracksDailyAccrualAfterReAge` and now asserts near-equality: `|growth − accrualActivity| ≤ 0.01`, so 0.01-vs-5.77 partial freezing fails. 2: The formula has been unified. Added `RepaymentPeriod.calculateFixedInterestTillDate(LocalDate)`, both variants now share one private `prorateFixedInterest(elapsedDays)` core and `scaleFixedInterestTillDate` is 3 lines delegating to it. The zero-length divergence they spotted is also gone. Both now return full fixed interest there (adopting the existing method's behaviour) and a test pins that agreement. 3: 6 tests added to RepaymentPeriodTest: before start → zero, prorated inside (1/30, 15/30), on due date → full, past due → full, zero-length → full, no fixed interest → zero, plus both-variants-agree. 5: `assertNotNull` guards on both reads of `getTotalUnpaidPayableNotDueInterest()`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
