Bhavya-Sonigra opened a new pull request, #6435: URL: https://github.com/apache/fineract/pull/6435
Closes FINERACT-415 ## Description Updated `validateGuaranteeParams` in `LoanProductDataValidator.java` to enforce strict equality (`!= 0`) instead of a loose less-than check (`< 0`). Previously, the Fineract API allowed loan product creation if the mandatory guarantee was strictly greater than the sum of the own funds and guarantor funds, leaving the remaining balance completely unaccounted for in the database. This patch ensures the API strictly validates that the `mandatoryGuarantee` is exactly equal to the sum of `minimumGuaranteeFromOwnFunds` and `minimumGuaranteeFromGuarantor` (or exactly equals one of them if the other is null/zero) before allowing creation or updates. Payload rejections now return the `must.be.equal.to.sum.of.own.and.guarantor.funds` error code. ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [x] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [x] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [x] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes - [x] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). - [x] If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately. - [x] I followed the [AI Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
