Aman-Mittal commented on PR #547: URL: https://github.com/apache/fineract-backoffice-ui/pull/547#issuecomment-5645742353
Pushed a fix for the failing **E2E (mobile viewport)** job, and rebased onto current `main`. The failure was caused by this PR, but it surfaced in a spec this PR did not originally contain. `DUAL_VIEWPORT_SPECS` gains the glob `**/*date-picker-revisit.spec.ts`, which also matches `client-date-picker-revisit.spec.ts` — merged from #546 while this branch was open. That spec reached the client list by clicking the sidebar link, which is collapsed at phone width, so it timed out on the click as soon as the glob pulled it into the mobile project. Nothing about the component change was wrong; the new coverage just reached a spec that had only ever run on desktop. It now navigates to the list by URL. The revisit that triggers the bug still happens in-app through the list's create button, so the spec covers the same failure at both viewports. Verified on the rebased branch: - `npx playwright test --project=mobile` — 19 passed, the whole mobile project including `mobile-shell` and `guidance-tour` - `npx playwright test date-picker-revisit --project=mocked` — 3 passed Before pushing I reproduced CI's exact tree locally (this branch merged with `main`) and confirmed the mobile job failed there for this reason, then that the same tree passes with the navigation change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
