Aman-Mittal opened a new issue, #575:
URL: https://github.com/apache/fineract-backoffice-ui/issues/575

   In dark mode every client name and account number in the list and detail 
tables is rendered in a hardcoded Material indigo that was never mapped for the 
dark palette.
   
   > **Screenshot:** _Clients list in dark theme — the `Account No` and `Name` 
columns._ (attached below)
   
   ## Measurement
   
   | | |
   |---|---|
   | Foreground | `#3F51B5` (`rgb(63, 81, 181)`) |
   | Background | `#1E1E1E` (the card surface) |
   | Contrast | **2.43:1** |
   | WCAG AA minimum (14 px, normal weight) | 4.5:1 |
   
   An automated sweep of every leaf text node on the Clients list (computed 
colour against the resolved ancestor background, with the large-text allowance 
applied) returned **20 failing nodes**, all of them this one colour. These 
links are the primary means of navigating into a record, so the failure sits on 
the screen's main affordance.
   
   ## Root cause
   
   The colour is a literal hex that never consults the theme:
   
   ```scss
   .clickable-link {
     color: #3f51b5;
     font-weight: 500;
     cursor: pointer;
     text-decoration: none;
   }
   ```
   
   `src/app/features/clients/clients-list.component.ts:171`
   
   The same block is copied into 
`src/app/features/clients/client-view.component.ts:1078`.
   
   The dark theme already publishes a token that passes: `--primary-color: 
#3498db`, which measures ~4.7:1 on `#1E1E1E`. It simply isn't used here. In 
light mode `#3F51B5` on white is ~8:1, which is why this only shows up in dark 
mode.
   
   ## Suggested fix
   
   ```scss
   .clickable-link {
     color: var(--primary-color);
     ...
   }
   ```
   
   Both copies drift independently today, so this is a good moment to hoist 
`.clickable-link` into global styles (or the shared table component) rather 
than fixing it twice.
   
   ## Note on scope
   
   Aside from this one colour, a full sweep of the dashboard and the Clients 
list found **no other contrast failures** in either theme — light mode came 
back clean. This is a single token mapping, not a broad palette problem.
   
   ## Reproduction
   
   1. Sign in, switch to dark mode via the header toggle.
   2. Open **Clients**.
   3. Sample any value in the `Account No` or `Name` column against its row 
background.
   
   ## Tested against
   
   Deployed build of `main`, Chrome, 1280x800 and 390x844. Line references are 
against `27d5a441`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to